Skip to content

feat(review): add bounded adaptive review delegation - #1770

Merged
limityan merged 2 commits into
GCWing:mainfrom
limityan:yanzhn/adaptive-review-focused-checks
Jul 26, 2026
Merged

feat(review): add bounded adaptive review delegation#1770
limityan merged 2 commits into
GCWing:mainfrom
limityan:yanzhn/adaptive-review-focused-checks

Conversation

@limityan

@limityan limityan commented Jul 26, 2026

Copy link
Copy Markdown
Collaborator

Summary

  • Keep one primary Review and add bounded additional review work only for concrete unresolved questions with independent value.
  • Select concise review capabilities from the built-in worker, compatible code-review Skills, and configured read-only review agents; load full guidance only after the work is admitted.
  • Bind each additional check to a typed question, immutable target fingerprint, assigned changed paths, expected evidence, and capability fingerprint.
  • Present one Review result: clear additional-check progress, sanitized failures, localized report sources, and no Skill or agent identity leakage.

Bounded behavior

Review path Additional work Parallel limit Automatic retry
Standard 0-2 additional checks 2 Disabled
Strict 0-3 shared calls, including optional independent validation 2 Disabled
Managed large target Existing bounded file packets; review focus does not multiply packets 2 Disabled for new adaptive work
Remote workspace Adaptive additional checks unavailable until scope isolation is guaranteed N/A N/A

The Review parallelism setting allows serial or two-way execution. It changes concurrency, not review scope or the amount of work admitted.

Safety and compatibility

  • Reject duplicate question-and-scope work and enforce shared worker and validation budgets in the runtime.
  • Restrict GetFileDiff, Read, and Grep to the assigned target identity; fail closed for path escape, case aliases, alternate data streams, device paths, symlink aliases, and hard-link aliases.
  • Include selected guidance and explicit model preference in the capability fingerprint; source-qualified custom-agent lookup avoids same-name collisions.
  • Keep historical manifests and managed packet recovery compatible. Adaptive additional checks remain unavailable in remote workspaces, while existing managed remote compatibility is unchanged.

Product and documentation

  • Keep Review as the primary user action and result; use Additional check / 补充检查 only when an individual supporting task must be identified.
  • Replace fixed reviewer-roster and fixed-dimension language with problem-driven review behavior.
  • Remove internal call limits, token budgets, and source identities from consent, task cards, reports, and Markdown exports.
  • Use count-safe, localized reliability messages in English, Simplified Chinese, and Traditional Chinese.
  • Update the Review architecture, lifecycle, and SDLC requirements to describe the implemented boundaries and compatibility behavior.

This change does not add a Review-specific telemetry service, cache, scheduler, Harness, or second runtime. Existing logs remain the diagnostic surface; no numerical latency or token reduction is claimed without production measurements.

Verification

  • cargo check --workspace
  • cargo test -p bitfun-agent-runtime deep_review --lib (128 passed)
  • cargo test -p bitfun-agent-runtime deep_review::team_definition::tests --lib (3 passed on the rebased head)
  • cargo test -p bitfun-core agentic::tools::implementations::task::tests --lib (70 passed)
  • cargo test -p bitfun-core agentic::deep_review --lib (9 passed)
  • cargo test -p tool-runtime grep_search --lib (6 passed)
  • Targeted Web UI suite (9 files, 142 passed on the rebased head)
  • pnpm run type-check:web
  • pnpm run i18n:audit (0 warnings on the rebased head)
  • pnpm run check:repo-hygiene
  • node scripts/check-core-boundaries.mjs
  • git diff --check

Independent final reviews covered architecture and scope, correctness and security boundaries, and product and i18n behavior. The only product P2 found was the English count grammar; it is fixed and the re-review found no remaining P0-P2 issues.

limityan added 2 commits July 26, 2026 15:20
Select focused review guidance only for concrete unresolved questions, enforce target-bound read scopes and shared budgets, and keep source identities out of the product UI. Preserve managed and historical manifests while capping new Review concurrency and retries.
@limityan
limityan force-pushed the yanzhn/adaptive-review-focused-checks branch from 7b6768d to 18afdfc Compare July 26, 2026 07:21
@limityan limityan changed the title feat(review): add bounded adaptive focused checks feat(review): add bounded adaptive review delegation Jul 26, 2026
@limityan
limityan merged commit c404fc2 into GCWing:main Jul 26, 2026
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant